Skip to content

Fix syntax error in test PropertyHook#712

Merged
jaapio merged 2 commits intophpDocumentor:7.xfrom
AJenbo:patch-1
Mar 3, 2026
Merged

Fix syntax error in test PropertyHook#712
jaapio merged 2 commits intophpDocumentor:7.xfrom
AJenbo:patch-1

Conversation

@AJenbo
Copy link
Contributor

@AJenbo AJenbo commented Jan 4, 2026

php -l

  • Cannot specify default value for virtual hooked property

@AJenbo
Copy link
Contributor Author

AJenbo commented Jan 4, 2026

The failing tests also fail on the 6.x branch so are not related to this PR

@jaapio jaapio changed the base branch from 6.x to 7.x March 2, 2026 21:36
@jaapio
Copy link
Member

jaapio commented Mar 2, 2026

can you please rebase against 7.x, so we can proceed an merge this.

@AJenbo
Copy link
Contributor Author

AJenbo commented Mar 3, 2026

Done, please merge before 8.0 :D

@jaapio
Copy link
Member

jaapio commented Mar 3, 2026

Thanks a lot. I will make sure this is merged soon.

@jaapio jaapio enabled auto-merge March 3, 2026 08:12
@jaapio jaapio disabled auto-merge March 3, 2026 08:24
@jaapio jaapio merged commit 7f840ef into phpDocumentor:7.x Mar 3, 2026
34 checks passed
@AJenbo AJenbo deleted the patch-1 branch March 3, 2026 09:30
@AJenbo
Copy link
Contributor Author

AJenbo commented Mar 3, 2026

Thanks, for context we are using this as a test case in pdepend / phpmd so not having false parser errors nice a nice.

@jaapio
Copy link
Member

jaapio commented Mar 3, 2026

Do you need a release for that?

@AJenbo
Copy link
Contributor Author

AJenbo commented Mar 3, 2026

That might be the case, but don't worry about it, for now it's a manual process, and it needs to spread though our dependency tree as well, so don't sweat it, just wanted to let you know another way this project is helping others :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants